[8.x] PHP 8.1 Support #39034
Merged
[8.x] PHP 8.1 Support #39034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
requested changes
Sep 29, 2021
driesvints
force-pushed
the
php8.1-fixes
branch
2 times, most recently
from
997118a to
219cc60
Compare
|
Predis fix merged here: predis/predis@92adf32 |
GrahamCampbell
requested changes
Sep 30, 2021
driesvints
force-pushed
the
php8.1-fixes
branch
from
089ad7d to
7811c06
Compare
GrahamCampbell
requested changes
Oct 4, 2021
|
@GrahamCampbell have patience 😅 |
|
@driesvints I don't follow? |
|
I will change it once Till has tagged a new release. |
|
I just don't get why change it to |
driesvints
force-pushed
the
php8.1-fixes
branch
from
a814f03 to
6dce125
Compare
driesvints
force-pushed
the
php8.1-fixes
branch
from
d746ca8 to
2dec4e1
Compare
* Make ArgonHasher aware of argon provider If sodium provides the argon2 then threads must be 1, if "standard" (libargon2) is the provider it can be 1 or 2. Not sure why this seems to only affect PHP 8.1 however as the behaviour seems to date back quite a bit. https://github.com/php/php-src/blob/2a3760a2d12b1a4c5c0207386b6cae84e404ee7e/ext/sodium/sodium_pwhash.c#L197 * remove skips for Hashing tests
driesvints
force-pushed
the
php8.1-fixes
branch
from
f873656 to
6fa1eaf
Compare
|
Thanks @mallardduck, @tillkruss, @GrahamCampbell and everyone else that worked on this PR! :) |
chu121su12
pushed a commit
to chu121su12/framework
that referenced
this pull request
Oct 23, 2021
* Remove platform requirement * Enable prefer-lowest builds for PHP 8.1 * Bump whoops * Minimum symfony version * Bump carbon * Try dev * Require commonmark * Add phpunit * Bump predis * More clearly describe failing mail tests * Remove skips for Redis tests * try predis dev * Make ArgonHasher aware of argon provider (laravel#39046) * Make ArgonHasher aware of argon provider If sodium provides the argon2 then threads must be 1, if "standard" (libargon2) is the provider it can be 1 or 2. Not sure why this seems to only affect PHP 8.1 however as the behaviour seems to date back quite a bit. https://github.com/php/php-src/blob/2a3760a2d12b1a4c5c0207386b6cae84e404ee7e/ext/sodium/sodium_pwhash.c#L197 * remove skips for Hashing tests * Enable tests * Re-skip test * Adjust skips * Re-enable dynamodb tests * Bump predis * Bump PHP AWS SDK * Remove test skipping * Update tests.yml * Update tests.yml * Bump SwiftMailer * string fallbacks * Update phpunit.xml.dist * Remove skips Co-authored-by: Dan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains more PHP 8.1 fixes:
prefer-lowestbuilds