[8.x] Notification assertions respect shouldSend
method on notification
#38979
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for notification's
shouldSend
method were added in PR #37930. This method allows users to add some logic to cancel sending notification based on given notifiable and channel.Problem
However, testing methods
assertSentTo
andassertNotSentTo
weren't aware about this feature and didn't behave as expected (reported here as well #38909).For example, take this code:
Now, when testing whether notification hasn't been sent, we won't get expected assertion result:
Solution
This PR adds support of
shouldSend
to notification'sassertSentTo
andassertNotSentTo
methods. So now whenshouldSend
is presented on notification class and returns false for some notifiable,assertSentTo
andassertNotSentTo
can be used to check that behavior.Fixes #38909