[8.x] Fix sometimes conditions that add rules for sibling values within an array of data #38899
Conversation
|
@jasonlewis do you wanna give it a quick try? |
|
Hey mate I'll hopefully give it a whirl tomorrow morning (Australia) if Taylor hasn't already gotten around to it. Cheers! |
|
The difference after your original PR @NickSdot is that the I pushed a new commit to this PR to address that as I think it is the root cause - I also added another test that was failing without my fix. |
|
Also good to see you @jasonlewis ❤️ |
|
Cheers fellas! Can confirm this fixed our cases (tests are now green across the board). Much appreciated and sorry I couldn't help much more. Hope all is well @taylorotwell! 😄 |
| @@ -4392,6 +4392,18 @@ public function testValidateSometimesImplicitEachWithAsterisksBeforeAndAfter() | |||
| }); | |||
| $this->assertTrue($v->passes()); | |||
|
|
|||
| return; | |||
There was a problem hiding this comment.
Is this return supposed to be here? Seems like it is exiting the test case prematurely.
…in an array of data (laravel#38899) * Hotfix for laravel#38443 (comment) * Fix style * fix bug * Update ValidationValidatorTest.php Co-authored-by: Taylor Otwell <[email protected]> Co-authored-by: Taylor Otwell <[email protected]>
@taylorotwell Hotfix and tests for #38443 (comment)