[8.x] Revert PR #38552

[driesvints]

This PR reverts #38552 because it's a breaking change. Any Laravel app that doesn't has a password reset route will see their app break.

See laravel/nova-issues#3542 & the comments in #38552

[GrahamCampbell]

Do we need another patch release right after this?

[driesvints]

Probably best.

[Jubeki]

Wouldn't it also be possible to check if the route exists and only then generate the link? otherwise pass null to the creating function.

[driesvints]

@Jubeki what code do you propose? Can you send in a PR?

[Jubeki]

protected function resetUrl($notifiable)
{
    if (static::$createUrlCallback) {
        return call_user_func(static::$createUrlCallback, $notifiable, $this->token);
    }
    
    if(Route::has('password.reset') {
        return url(route('password.reset', [
            'token' => $this->token,
            'email' => $notifiable->getEmailForPasswordReset(),
        ], false));
    }
    
    return null;
}

Something like this?

[Jubeki]

I can send in a PR

[crynobone]

I personally would prefer static method to generate reset url if needed. ResetPassword::url(string $token)

[Jubeki]

My idea is also not really good, because it should provide a default URL and not null. No idea what a good default URL is though.