[8.x] Remove mapWithKeys from HTTP Client headers() methods
#38643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnanney
changed the title
mapWithKeys from HTTP Client Request and Response headers() methodsmapWithKeys from HTTP Client headers() methods
victorvilella
pushed a commit
to cdsistemas/framework
that referenced
this pull request
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These
headers()methods have been this way since the initial port of ZTTP in 65b8d50. ThegetHeaders()method in the PSR-7 Request and Response objects already return the headers asstring[][], so thismapWithKeysusage is essentially a no-op.I didn't feel the need to add any specific tests for this, as the
header()method is used internally inhasHeader(), which is tested directly or indirectly 21 times inHttpClientTest, sufficient to show that the expected header array is the same as it was before.