[8.x] Add unprocessable test response assertion #38553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add assertUnprocessable method * Add test
timmartin19
added a commit
to timmartin19/framework
that referenced
this pull request
Sep 1, 2021
Inspired by PR laravel#38553. A readability enhancement in the same manner. Just like `assertOk`, `assertUnauthorized` and company this adds an `assertBadRequest` to ensure that a [400 Bad Request](https://datatracker.ietf.org/doc/html/rfc7231#section-6.5.1) was sent in the response. The intention is to increase readability and add broader support to the existing suite of response code assertions which are much easier to understand. This introduces no breaking changes since it does not modify any existing methods. Also introduced a test case for the assert error path and the path where there is no assertion error.
victorvilella
pushed a commit
to cdsistemas/framework
that referenced
this pull request
Oct 12, 2021
* Add assertUnprocessable method * Add test Co-authored-by: Joby Harding <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposes a new
->assertUnprocessable()method onTestResponseto compliment the existing descriptive convenience methods.I use
->assertOk(),->assertUnauthorized(),->assertForbidden()& friends in tests because they read really clearly and benefit from showing up in my editor's tab autocomplete so there's a small quality of life enhancement.Working on a complex project with a lot of validation I've been wishing there was an equivalent for
->assertStatus(422)or the more human but long winded->assertStatus(Response::HTTP_UNPROCESSABLE_ENTITY).The addition is syntactic sugar and does not modify any existing methods so there are no breaking changes.