[8.x] Allow passing when callback to Http client retry method #38531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
A little papercut I have, this adds support for passing a
$when
callback to theHttp::retry()
method which is already supported by theretry
helper that is used to handle the Http client retries. There are no existing tests forHttp::retry()
so this PR does not contain any.When Callback already exists in the retry helper
I have just noticed whilst writing this that the
$when
callback isn't actually documented on theretry
helper docs (https://laravel.com/docs/8.x/helpers#method-retry). It is a very useful feature where you can decide whether to continue retrying or to throw the current exception by returning aboolean
from the callback:Use with Http client
This PR adds the
$when
support to the Http client, which can be useful if as seen in the example you only want to retry when it gets a connection failure: