Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Use actual countable interface on MessageBag #38227

Merged
merged 2 commits into from
Aug 3, 2021

Conversation

driesvints
Copy link
Member

@driesvints driesvints commented Aug 3, 2021

Instead of defining our own declaration of Countable, let's use the actual PHP interface. This is the only contract in Laravel that defines its own count method.

I've also removed the Arrayable interface from the MessageBag class because it's already defined through the MessageBag interface.

Ideally, both Arrayable and Countable wouldn't exist on the MessageBag interface but only on the concrete implementation.

@driesvints driesvints changed the title Use actual countable interface on MessageBag [8.x] Use actual countable interface on MessageBag Aug 3, 2021
@taylorotwell taylorotwell merged commit 1fd1bb1 into 8.x Aug 3, 2021
@taylorotwell taylorotwell deleted the use-actual-countable-interface branch August 3, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants