[6.x] Remove hardcoded Carbon reference from scheduler event #38063
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the date that is used to check if a scheduled event is due to the
Date
facade. I ran into a problem where my tests are failing because my application uses a different date class (CarbonImmutable
)The following test will always fail because the scheduler calls
Carbon
directly, which at this point does not have a test instance set (becauseCarbonImmutable
is used)This shouldn't introduce any breaking changes because:
illuminate/console
already requiresilluminate/support
\Illuminate\Console\Scheduling\Event
class already uses theDate
facade everywhere except the line that was changed