[8.x] Makes the retrieval of Http client transferStats safe #37597
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there!
The Http Client returns some really nice details in the
handlerStats
method. However, when faking a request inside a test, thetransferStats
object is null. This causes an error when attempting to call thehandlerStats
method. This PR updates thehandlerStats
call by wrapping it in anoptional
call and returning an empty array by default. This makes consuming code much cleaner by no longer requiring a try/catch statement.There is another option, which is that we return a new
Fluent
fromhandlerStats
, but that would be a breaking change because previous try/catches would now pass but return null, which could cause undesired side-effects. If that is desirable to you, let me know and I'll write a PR for 9.x that will expand on this one.Thanks for your time guys :-)
Regards,
Luke