[8.x] Columns in the order by list must be unique #37582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MySql is ok with it, but SqlServer error out. See a similar issue here: laravel/nova-issues#1621
|
@Javdu10 Would be a good idea to add a regression test using |
|
@BrandonSurowiec done, I'm not sure what form it should have, let me know if it's correct |
|
@Javdu10 Looks good to me! |
taylorotwell
added a commit
that referenced
this pull request
Jun 10, 2021
This reverts commit f0c6f4d.
taylorotwell
added a commit
that referenced
this pull request
Jun 10, 2021
|
This PR was reverted because it continued to break things. See #37647 |
|
Hello @driesvints, thank you for the notice! @taylorotwell, that person's test pass if it's not overridable by calling order by again (see: #37505 (comment)) So what should we do? It would be fixed if scopes are executed before applying |
|
@Javdu10 I doubt we'll be making more changes to this for the time being, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the inconveniences...
See: #37505 for more context
Fixes: #37581