Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Allow connecting to read or write connections with the db command #37530

Merged
merged 1 commit into from
May 31, 2021
Merged

[8.x] Allow connecting to read or write connections with the db command #37530

merged 1 commit into from
May 31, 2021

Conversation

themsaid
Copy link
Member

Fixes #37520

This pr allows passing the connection type to the DB command:

php artisan db mysql::read

@themsaid themsaid mentioned this pull request May 29, 2021
Closed
@taylorotwell taylorotwell merged commit fdd6a3a into laravel:8.x May 31, 2021
taylorotwell added a commit that referenced this pull request May 31, 2021
@taylorotwell
Revert " allow connecting to read or write connections with the db co…
4af8059 
…mmand (#37530)"

This reverts commit fdd6a3a.
@taylorotwell taylorotwell mentioned this pull request May 31, 2021
Merged
taylorotwell added a commit that referenced this pull request May 31, 2021
@taylorotwell
Revert " allow connecting to read or write connections with the db co…
3bde8d5 
…mmand (#37530)" (#37546)

This reverts commit fdd6a3a.
@taylorotwell
Copy link
Member

@themsaid can you resubmit this with an option for --read or --write?

@themsaid
Copy link
Member Author

@taylorotwell done: #37548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI DB session not working on read/write connections
2 participants
@themsaid @taylorotwell