[8.x] Fix eager loading one-of-many relationships with multiple aggregates #37436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes eager loading one-of-many relations with multiple aggregates.
Before fix: http://sqlfiddle.com/#!9/cef514/7
After fix: http://sqlfiddle.com/#!9/cef514/8
All inner join sub queries must be grouped by the relationship group columns, not the previous aggregated column from the previous sub query.
The issue was pointed out by @sblawrie in #37362 (comment)