[8.x] Fixed aggregates (e.g.: withExists) for one of many relationships #37413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes aggregates like
withExists
when used for one of many relationships (#37362).The problem was that the join clause was passed to the existence query, but not the bindings.
The joins are now added included bindings in the following method:
framework/src/Illuminate/Database/Eloquent/Relations/Concerns/CanBeOneOfMany.php
Lines 192 to 197 in 3baf475
Used here in HasOne:
framework/src/Illuminate/Database/Eloquent/Relations/HasOne.php
Lines 71 to 78 in 3baf475
And MorphOne:
framework/src/Illuminate/Database/Eloquent/Relations/MorphOne.php
Lines 69 to 76 in 3baf475