[8.x] Add withExists method to QueriesRelationships #37302
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is another implementation of #37295 which adds less code to the framework.
I won't be sad if it is not merged but I wanted to provide another way of implementing the same behaviour.
For more information about the motivations of this feature, I add here the original description.
This PR adds
withExists
method toQueriesRelationships
.If we want to list our
User
s with an extra columnsis_author
(based on the fact that the user wrote aPost
), at the moment we can only do something likeIt works but it is not very efficient as the database needs to count every posts whereas we only need to know if there is at least one of them.
With this PR, we could simply do an existence check with sql
exists
wich is more efficientThe column name can also be aliased
Relations can be filtered and multiple relation existences can be fetched at the same time :
In a future PR we could add
loadExists
for bothModel
andIlluminate\Database\Eloquent\Collection