Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Add str method to the HTTP Client response #37225

Closed
wants to merge 2 commits into from
Closed

[8.x] Add str method to the HTTP Client response #37225

wants to merge 2 commits into from

Conversation

foremtehan
Copy link
Contributor

We have collect method in the Response class #36331

It would be nice also to have str method so instead of:

Str::of(Http::get('https://example.com')->body())->matchAll('~div~')

can be :

Http::get('https://example.com')->str()->matchAll('~div~')

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

@foremtehan foremtehan deleted the patch-1 branch May 3, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants