[6.x] Fix nullable values for required_if #37128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several things:
nullable
values the same way as we do forboolean
values. This will make sure that if someone addsnull
to these rules, it'll get properly handled for the targetted key's value.if (! Arr::has($this->data, $parameters[0])) {
part that was added to each of them. This was already expected I believe but should now fail early.if (is_null($value)) {
toFormatsMessages
so that validation messages can display things likeThe baz field is required when foo is null.
. This might be a bigger breaking change so if you want that part reverted I'll do so. Keep in mind that that will cause the validation message to displayThe baz field is required when foo is .
instead.I'd very much like a some second pair of eyes on this. @timacdonald @jessarcher if you're willing?