[8.x] fix JsonResponse::fromJasonString() double encoding string #37076
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Illuminate\Http\JsonResponse class inherits a static fromJsonString() method from the base Symfony\Component\HttpFoundation\JsonResponse class for creating a JsonResponse from an already encoded JSON string, but because of changes to the constructor signature it does not perform as expected, returning a response with the provided string reencoded as a literal string. While you can achieve the desired result like so:
(and that's probably the preferred way to do it anyway) it seems wrong to just leave the broken function there.