Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Include dispatchSync in the DispatchesJobs trait #37063

Merged
merged 3 commits into from
Apr 20, 2021
Merged

[8.x] Include dispatchSync in the DispatchesJobs trait #37063

merged 3 commits into from
Apr 20, 2021

Conversation

JacobBennett
Copy link
Contributor

Include dispatchSync in the DispatchesJobs trait, allowing users to use the new method when dispatching jobs from a controller directly.

@driesvints driesvints changed the title Update DispatchesJobs.php [8.x] Include dispatchSync in the DispatchesJobs trait Apr 20, 2021
@driesvints
Copy link
Member

@JacobBennett can you also add the deprecation notice to the dispatchNow method in the same fashion as we did in other places for dispatchNow?

@taylorotwell taylorotwell merged commit f79b684 into laravel:8.x Apr 20, 2021
@JacobBennett JacobBennett deleted the patch-2 branch April 21, 2021 02:14
@browner12
Copy link
Contributor

For reference:

#32559

#36834

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints driesvints approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JacobBennett @driesvints @browner12 @taylorotwell