[8.x] Add setPusher() to PusherBroadcaster::class #37033
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR only add a
setPusher()
to the PusherBroadcaster class.The reason is the
pusher
SDK instance is constructed from the configs usingapp_id
,key
andsecret
.When we register the channels for broadcasting during the Application boot phase this is cached inside the BroadcastManager singleton.
In an application with many pusher configurations saved in database (ex: multitenant) those configs need to be switch in a middleware for each request.
Without a setter to change the Pusher SDK instance we need to hack using reflexion or forget the driver and then re-configure it.
Thanks :-)