Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Fix clone() on EloquentBuilder #36924

Merged
merged 2 commits into from
Apr 9, 2021
Merged

[8.x] Fix clone() on EloquentBuilder #36924

merged 2 commits into from
Apr 9, 2021

Conversation

Propaganistas
Copy link
Contributor

@Propaganistas Propaganistas commented Apr 9, 2021 •
edited
Loading

This PR fixes clone() usage on EloquentBuilder.

clone() is currently being forwarded to the underlying QueryBuilder.

Now, here's the thing:

clone $builder effectively clones the underlying QueryBuilder object, but $builder->clone() doesn't. References are kept so this is basicly an unexpected noop.

@Propaganistas Propaganistas mentioned this pull request Apr 9, 2021
Merged
@driesvints driesvints changed the title Fix clone() on EloquentBuilder [8.x] Fix clone() on EloquentBuilder Apr 9, 2021
@taylorotwell taylorotwell merged commit bf3d5e3 into laravel:8.x Apr 9, 2021
@Propaganistas Propaganistas deleted the clone-eloquent-builder branch April 10, 2021 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Propaganistas @taylorotwell