[8.x] Use standard InvalidArgumentException when json_encode() failed
#36868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already throwing the same error https://github.com/laravel/framework/blob/8.x/src/Illuminate/Http/JsonResponse.php#L75 Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
driesvints
approved these changes
Apr 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already throwing the same error https://github.com/laravel/framework/blob/8.x/src/Illuminate/Http/JsonResponse.php#L75
At first, considered using
JSON_THROW_ON_ERRORbut it would be weird to throw a different exception on different classes (See above). We should definitely revisit this for 9.x release.Signed-off-by: Mior Muhammad Zaki [email protected]