Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Add missing temporary_url when creating flysystem #36860

Merged
merged 1 commit into from
Apr 5, 2021
Merged

[8.x] Add missing temporary_url when creating flysystem #36860

merged 1 commit into from
Apr 5, 2021

Conversation

lakuapik
Copy link
Contributor

@lakuapik lakuapik commented Apr 3, 2021

When we set s3 config temporary_url to override Storage::temporaryUrl() it does not work.

Here #36612 the key was renamed to temporary_url

if (! is_null($url = $this->driver->getConfig()->get('temporary_url'))) {

But here the temporary_url key is not included

$config = Arr::only($config, ['visibility', 'disable_asserts', 'url']);

This PR resolve that issue.

@GrahamCampbell GrahamCampbell changed the title Add missing temporary_url when creating flysystem [8.x] Add missing temporary_url when creating flysystem Apr 3, 2021
@taylorotwell
Copy link
Member

Flysystem doesn't seem to accept a temporary_url configuration value? Why would we pass it to them?

@driesvints
Copy link
Member

@taylorotwell it was added here: #36612

@taylorotwell taylorotwell merged commit a227942 into laravel:8.x Apr 5, 2021
@lakuapik lakuapik deleted the patch-filesystem branch April 26, 2021 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants