[8.x] Fix blade compiler regex issue

[driesvints]

Draft PR with failing test for a current issue with Blade components where a single ) is passed as a string argument. I've tracked it down to the regex below that doesn't seems to quite parse things correctly. Every attempt I made so far to fix it broke something else in the compiler.

framework/src/Illuminate/View/Compilers/BladeCompiler.php

Line 420 in d8a53a0

'/\B@(@?\w+(?:::\w+)?)([ \t]*)(\( ( (?>[^()]+) | (?3) )* \))?/x', function ($match) {

Update: thanks to @jasonmccreary for fixing this 🥳

Fixes #36815

[taylorotwell]

I'm scared but we'll give it a shot. 😅

[jasonmccreary]

Agreed. The idea is to handle any quoted strings separately. This is a bit naive to all the various ways one may quote strings in PHP. But it should solve the immediate issue with the current Regex approach. Supporting more complex syntax will likely require a more complex approach.

[selcukcukur]

https://regexr.com/5psod Too many regex syntax errors.

[jasonmccreary]

@selcukcukur PHP uses PCRE - https://regexr.com/5pspt

[selcukcukur]

@jasonmccreary I skipped that part, sorry 😅

[shaffe-fr]

Hi @driesvints, this PR caused an exception for the following case:

@php($label = new HtmlString(__( 'forms.terms', [ 'link' => 'I don\'t'])))
<x-input-checkbox name="terms" :label="$label" required/>

The new regex seems to have issues with escaping (escaped apostrophe \' in my example).

[jasonmccreary]

@shaffe-fr, it's currently a rather naive check for quoted strings. I'll see if I can adjust it to account for basic escaping. But I do worry we're pushing the limits of what this regex can do in a single pass.

[taylorotwell]

@shaffe-fr just do <?php your code ?> 😓

[shaffe-fr]

I understand that I can do this differently, I just wanted to indicate a small regression. Sorry for the inconvenience.

[driesvints]

@shaffe-fr thanks for notifying us. For now please use Taylor's suggestion.

[selcukcukur]

The last PR pushes the boundaries very much, I think this should not be applied.