[8.x] Deprecate MocksApplicationServices trait #36716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately this annotation only makes the trait show up as deprecated:
Calling methods doesn't show that they are deprecated:
|
|
@SjorsO That's a bug in phpstorm. Please report it to them. |
|
@SjorsO yeah think that's an issue with PhpStorm. I remember methods from deprecated traits being marked as well in the past. If they aren't anymore then something has changed. |
|
@driesvints You can use the "trigger_deprecation()" function in Symfony to deliver a deprecation message to users. |
|
@selcukcukur I don't think we should use language functionality for this. The annotation is fine enough on its own. |
|
For the PHPStorm bug, please vote here: https://youtrack.jetbrains.com/issue/WI-38853 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MocksApplicationServiceshas become redundant with the new Facade mocking functionality.