Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Support username parameter for predis #36299

Merged
merged 1 commit into from
Feb 17, 2021
Merged

[8.x] Support username parameter for predis #36299

merged 1 commit into from
Feb 17, 2021

Conversation

SPie
Copy link
Contributor

@SPie SPie commented Feb 17, 2021

As mentioned in Issue #36298 the username parameter got filtered on creating parameters for the predis connection.
I removed the filter to enable the username parameter for the connection.

@taylorotwell
Copy link
Member

So - surely we were filtering this for a reason? 🤔

@taylorotwell
Copy link
Member

Does this cause problems with using the PHP Redis extension?

@taylorotwell taylorotwell merged commit 918db60 into laravel:8.x Feb 17, 2021
@SPie
Copy link
Contributor Author

SPie commented Feb 17, 2021

Does this cause problems with using the PHP Redis extension?

I couldn't see any problems with the PHP Redis extension because the username is not used for it. It just won't work right now because Illuminate\Redis\Connectors\PhpRedisConnector uses only the password parameter. To use the PHP Redis extension with username and password requires to have an array as password parameter:

'session' => [
            'password' => [env('REDIS_USERNAME'), env('REDIS_PASSWORD')],
],

@GrahamCampbell GrahamCampbell changed the title Support username parameter for predis [8.x] Support username parameter for predis Feb 17, 2021
@jitendra-1217
Copy link
Contributor

Filed request to port the exact change into 6.x as well- #36762. Hoping it gets accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants