[8.x] Pipe through render and report exception methods #36032
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the
report
orrender
methods of an exception that were thrown in a view aren't being called by Laravel's exception handler. The reason for this is that these kind of view exceptions are wrapped in anErrorException
instance by Laravel here:framework/src/Illuminate/View/Engines/CompilerEngine.php
Line 79 in 3ab9f7a
Because there's no
render
orreport
method on anErrorException
instance the original ones aren't executed. I've solved this by introducing a newViewException
class that extendsErrorException
and pipes through anyrender
orreport
calls that are present on the previous exception instance. This should be non-breaking.Fixes #35493