[8.x] Throw ModelNotFoundException for sole in Eloquent #35902
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #35869
As suggested in comment #35869 (comment) by @taylorotwell , this PR throws a
ModelNotFoundException
when->sole()
is called from an Eloquent Query Builder and no records are found.This is particularly useful as
ModelNotFoundException
exceptions are handled automatically in HTTP requests by returning a 404 response.Maybe we should also add some kind of HTTP handling for the
MultipleRecordsFoundException
when called from an Eloquent Query Builder.