[8.x] Pass $key to closure in Collection and LazyCollection's reduce method as well #35878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
3604
to
3606
| $this->assertEquals('foobarbazqux', $data->reduceWithKeys(function ($carry, $element, $key) { | ||
| $this->assertEquals('foobarbazqux', $data->reduce(function ($carry, $element, $key) { | ||
| return $carry .= $key.$element; | ||
| })); |
There was a problem hiding this comment.
- Since we're still keeping
reduceWithKeysaround till 9.x (because it was already tagged), we shouldn't remove its test. - You can just add the
$keyto the other test. No need for 2 separate tests. - As discussed on that other PR, you can move the
reducemethod into theEnumeratesValuestrait.
There was a problem hiding this comment.
Will do, thanks for the comment
|
I think we're there.
|
|
Doesn't StyleCI remove those 4 spaces automatically? |
driesvints
changed the title
|
@mokhosh upon merging, not for forks. |
|
We're good then? Or do i fix style manually? |
|
@mokhosh it's always better if everything's green of course but StyleCI issues will get fixed automatically upon merging. |
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion we had here #35839 I've removed
reduceWithKeysand changed thereducemethod to pass$keyto its closure as well as$value.The previous test is there. I've just added another test for closures that accept the key, since I thought you might want to have one assertion per test. If you prefer to have one test per method and you don't care how many assertions are in one test, we can merge the two tests.