[8.x] Refresh the retryUntil time on job retry #35780
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much like how
attempts
is reset when a job is retried using the with thequeue:retry
command, this will now make it so theretryUntil
time is refreshed before being put back onto the queue. Using the jobs ownretryUntil
method of course!Without this, jobs that use a custom
retryUntil
method will always fail with aMaxAttemptsExceededException
if put back onto the queue with thequeue:retry
command AFTER the first time the job is run andretryUntil
is set in the job payload.This will provide a benefit to users who want to retry jobs sitting in
failed_jobs
with a customretryUntil
and don't want to have to update that value manually in the DB