-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.x] Add command to clean batches table #35694
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,11 +4,12 @@ | |
|
||
use Carbon\CarbonImmutable; | ||
use Closure; | ||
use DateTimeInterface; | ||
use Illuminate\Database\Connection; | ||
use Illuminate\Database\Query\Expression; | ||
use Illuminate\Support\Str; | ||
|
||
class DatabaseBatchRepository implements BatchRepository | ||
class DatabaseBatchRepository implements BatchRepository, Prunable | ||
{ | ||
/** | ||
* The batch factory instance. | ||
|
@@ -243,6 +244,29 @@ public function transaction(Closure $callback) | |
}); | ||
} | ||
|
||
/** | ||
* Prune all of the entries older than the given date. | ||
* | ||
* @param DateTimeInterface $before | ||
* @return int | ||
*/ | ||
public function prune(DateTimeInterface $before) | ||
{ | ||
$query = $this->connection->table($this->table) | ||
->whereNotNull('finished_at') | ||
->where('finished_at', '<', $before->getTimestamp()); | ||
|
||
$totalDeleted = 0; | ||
|
||
do { | ||
$deleted = $query->take(1000)->delete(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why don't you just use the query builder's each function? |
||
|
||
$totalDeleted += $deleted; | ||
} while ($deleted !== 0); | ||
|
||
return $totalDeleted; | ||
} | ||
|
||
/** | ||
* Convert the given raw batch to a Batch object. | ||
* | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
<?php | ||
|
||
namespace Illuminate\Bus; | ||
|
||
use DateTimeInterface; | ||
|
||
interface Prunable | ||
{ | ||
/** | ||
* Prune all of the entries older than the given date. | ||
* | ||
* @param DateTimeInterface $before | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing slash |
||
* @return int | ||
*/ | ||
public function prune(DateTimeInterface $before); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
<?php | ||
|
||
namespace Illuminate\Queue\Console; | ||
|
||
use Carbon\Carbon; | ||
use Illuminate\Bus\BatchRepository; | ||
use Illuminate\Bus\Prunable; | ||
use Illuminate\Console\Command; | ||
|
||
class PruneBatchesCommand extends Command | ||
{ | ||
/** | ||
* The console command signature. | ||
* | ||
* @var string | ||
*/ | ||
protected $signature = 'queue:prune-batches {--hours=24 : The number of hours to retain batch data}'; | ||
|
||
/** | ||
* The console command description. | ||
* | ||
* @var string | ||
*/ | ||
protected $description = 'Prune stale entries from the batches database'; | ||
|
||
/** | ||
* Execute the console command. | ||
* | ||
* @return void | ||
*/ | ||
public function handle() | ||
{ | ||
$count = 0; | ||
|
||
$repository = $this->laravel[BatchRepository::class]; | ||
|
||
if ($repository instanceof Prunable) { | ||
$hours = $this->option('hours'); | ||
|
||
$before = Carbon::now()->subHours($hours); | ||
|
||
$count = $repository->prune($before); | ||
} | ||
|
||
$this->info("{$count} entries deleted!"); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing slash