[8.x] When following redirects, terminate each test request in proper order #35604
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
followRedirects()
implementation applies both awhile
loop and recursion, causingKernel::terminate()
to be called in the incorrect order. 99% of the time this is not an issue, but in the case of terminating middleware or callbacks set up withApp::terminating()
, the termination callbacks will be executed in reverse order.For example, with two routes:
And the following middleware:
Given the following pseudo-test: