[8.x] Add table name as default morph type #35257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imanghafoori1
force-pushed
the
table_name_morph_type
branch
from
3c5be41 to
cc13615
Compare
imanghafoori1
force-pushed
the
table_name_morph_type
branch
from
cc13615 to
5d58b0f
Compare
|
@imanghafoori1 See above. This PR is broken. |
|
We'll need to revert this as it seems impossible to ever ship this with a working implementation. See my comment here: #35519 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the default value for morph type is the "namespaced classpath" of the model and the user should define an alias for each new model.
The PR lets the user change the default morph values to the table names with a single method call which is good enough since the table names often do not change and are unique.
Older projects can continue working unharmed as they were before. This is meant to be used for from-scratch projects.
For laravel 9.x it is possible to make the table name as default values and enable the legacy mode with a method call, for upgrading projects.