Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Allow custom broadcastWith in notification broadcast channel #35142

Merged
merged 3 commits into from
Nov 7, 2020
Merged

[8.x] Allow custom broadcastWith in notification broadcast channel #35142

merged 3 commits into from
Nov 7, 2020

Conversation

aalyusuf
Copy link
Contributor

@aalyusuf aalyusuf commented Nov 7, 2020

This allows overriding broadcastWith when broadcasting a notification.

Beneficial over toBroadcast when you have custom data shared across multiple notifications or when you don't need type/id for any reason.

@GrahamCampbell GrahamCampbell changed the title Allow custom broadcastWith in notification broadcast channel [8.x] Allow custom broadcastWith in notification broadcast channel Nov 7, 2020
@taylorotwell taylorotwell merged commit a9af73f into laravel:8.x Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aalyusuf @taylorotwell