[8.x] Proxy URL Generation in VerifyEmail
#34572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chanism in `ResetPassword`. This change increases interface consistency in the Notifications namespace. This change does not break compatability, as it adds a way to overwrite URL generation. If the developer does not provide a callback, the current URL generation is still used.
ghost
reviewed
Sep 29, 2020
| @@ -11,6 +11,13 @@ | |||
|
|
|||
| class VerifyEmail extends Notification | |||
| { | |||
| /** | |||
| * The callback that should be used to create the reset password URL. | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ghost
reviewed
Sep 29, 2020
| ); | ||
| if (static::$createUrlCallback) { | ||
| return call_user_func(static::$createUrlCallback, $notifiable); | ||
| } else { |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
I just kept it the same as it is written in ResetPassword::toMail, hence the else. I agree that it is not necessary...
ghost
reviewed
Sep 29, 2020
| } | ||
|
|
||
| /** | ||
| * Set a callback that should be used when creating the reset password button URL. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
driesvints
changed the title
VerifyEmailVerifyEmail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in relation to issue #28469 and idea #1635.
Provide a mechanism to create URLs in
VerifyEmailsimilar to the mechanism inResetPassword. This change increases interface consistency in the Notifications namespace. This change does not break compatability, as it adds a way to overwrite URL generation. If the developer does not provide a callback, the current URL generation is still used.(Would I need to PR against 7.x if I wanted to propose a backport to the 7.x branch?)