Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Add the Countable interface to AssertableJsonString #34284

Merged
merged 2 commits into from
Sep 11, 2020
Merged

[8.x] Add the Countable interface to AssertableJsonString #34284

merged 2 commits into from
Sep 11, 2020

Conversation

cbl
Copy link
Contributor

@cbl cbl commented Sep 11, 2020 •
edited
Loading

This pr adds the Countable interface to the new Illuminate\Testing\AssertableJsonString class. This adds downgrade compatibility to tests counting the decoded json response:

$this->assertCount(1, $response->decodeJsonResponse());

cbl added 2 commits September 11, 2020 11:53
@cbl
[8.x] Add the Countable interface to AssertableJsonString
6fe3c13 
This pr adds the Countable interface to the new `Illuminate\Testing\AssertableJsonString`. This adds downgrade compatibility to tests counting the decoded json response:

```php
$this->assertCount(1, $response->decodeJsonResponse());
```
@cbl
Apply fixes from StyleCI
7165836
@taylorotwell taylorotwell merged commit 463bdd9 into laravel:8.x Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints driesvints approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbl @driesvints @taylorotwell