Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Removed quotes when setting isolation level for mysql connections #33805

Merged
merged 1 commit into from
Aug 10, 2020

Conversation

duxthefux
Copy link
Contributor

Removed unnecessary quotes, which cause mysql error if isolation_level-config is provided.

@duxthefux
Copy link
Contributor Author

duxthefux commented Aug 10, 2020

@taylorotwell sry for the obsolete quotes, I removed them in another branch where we run tests against real mysql server, and missed to apply the change also to the MR. Sorry for that! 🤦

EDIT: Added test

@duxthefux duxthefux force-pushed the isolation-level-config branch from 40b709d to 2f573a7 Compare August 10, 2020 09:30
@taylorotwell taylorotwell merged commit bdf827c into laravel:7.x Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants