[7.x] Support the sink option when using Http::fake()
#33720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Guzzle
sinkoption allows you to save the body of the response directly to a file or resource. When using theHttpclient, sink works normally. As soon as you callHttp::fake(), the sink option stops working, making it impossible to test code that uses thesinkoption.This PR adds support for two common sink use-cases: saving to a file and writing to a stream. There might be more ways to use the sink option, but I couldn't figure out exactly how Guzzle handles sinking. We can fix other use-cases once people run into them.
This PR also adds a
sink()method to thePendingRequestclass. This makes it easier to use the option, and allows IDEs to help with auto completion.Fixes #33557