Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Add withoutEagerLoads function #33679

Closed
wants to merge 2 commits into from
Closed

[7.x] Add withoutEagerLoads function #33679

wants to merge 2 commits into from

Conversation

ahmedsayedabdelsalam
Copy link
Contributor

I have some models which use the $with property to automatically load related media

In one situation I have to store only the object without the eager loads I found that I can use the method without(['media'])
but what if in the future I added some loaded relations to so I have to update the without(['media', 'anotherRelation]) too

I found laravel has a method called setEagerLoads($arr) and I can pass an empty array [] to clear all loaded relations
but I think if the method name is similar to without method name would be easy to remember and more descriptive.

Screen Shot 2020-07-28 at 4 22 27 AM

@netpok
Copy link
Contributor

netpok commented Jul 28, 2020

In my opinion one should use the $with when the related models should be always loaded, for every other instance there are the scopes.

Also withoutEagerloads() is longer than setEagerLoads([]) and would promote the bad habit of using $with when not necessary so 👎 from me.

@driesvints driesvints changed the title Add withoutEagerLoads function [7.x] Add withoutEagerLoads function Jul 28, 2020
@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants