[8.x] Callable attributes are called with expanded definition

[bastien-phi]

On Laravel 7 and under, it is possible to define fatories like this :

$factory->define(MyModel::class, function(Faker $faker) {
    return [
        'total' => $faker->numberBetween(100, 1000),
        'part' => fn($attributes) => $faker->numberBetween(0, $attributes['total']),
        'rate' => fn($attributes) => $attributes['part'] / $attributes['total'],
    ];
});

Under Laravel 8, defining the factory with

public function definition() 
{
    return [
        'total' => $this->faker->numberBetween(100, 1000),
        'part' => fn($attributes) => $this->faker->numberBetween(0, $attributes['total']),
        'rate' => fn($attributes) => $attributes['part'] / $attributes['total'],
    ];
}

will fail because in rate callback, $attributes['part'] is the callback, not the actual value.

This example is maybe not very good but we have the same issue with

public function definition() 
{
    return [
        'user_id' => UserFactory::new(),
        'team_id' => fn($attributes) => User::find($attributes['user_id'])->team_id,
    ];
}

(here the $attributes['user_id'] is the factory)

[GrahamCampbell]

Could you add a couple of tests, please?

[taylorotwell]

I'm adding a few tests.