[8.x] Guess relation name in model factories #33450
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we could improve the way relationship are guessed.
Actually, the relationship is always pluralized and singular form of HasOne cannot be guessed. For example, a
User
having a has onesubscription
relation we always have to writeThis PR resolves correctly the relation just doing
I don't know if this should be used also on
hasAttached
method to be honest...If this needs tests, I would be happy to add them.