Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] Add substrCount to Stringable and Str #32393

Merged
merged 3 commits into from
Apr 15, 2020
Merged

[7.x] Add substrCount to Stringable and Str #32393

merged 3 commits into from
Apr 15, 2020

Conversation

crissto
Copy link
Contributor

@crissto crissto commented Apr 15, 2020

Saw the issue on laravel/ideas 2182 and though it would be a good little addition.

GrahamCampbell
GrahamCampbell requested changes Apr 15, 2020
View reviewed changes
src/Illuminate/Support/Str.php Outdated Show resolved Hide resolved
@GrahamCampbell GrahamCampbell changed the title Add: substrCount to Stringable and Str [7.x] Add: substrCount to Stringable and Str Apr 15, 2020
@GrahamCampbell GrahamCampbell changed the title [7.x] Add: substrCount to Stringable and Str [7.x] Add substrCount to Stringable and Str Apr 15, 2020
@taylorotwell taylorotwell merged commit cdd8918 into laravel:7.x Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamCampbell GrahamCampbell GrahamCampbell requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crissto @GrahamCampbell @taylorotwell