[7.x] Add HTTP client response body as object #32341
Merged
+29
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lets you access the
Http
client response body as anobject
.I also added tests to cover existing ways to access the response body.
Current state
Initially, I thought to pass a boolean to
json()
to tell if it should convert JSON asarray
orobject
.But the fact that
json()
is used to implementArrayAccess
, andjson(true)
isn't verbose at all, I went withobject()
Usage
Future
As most API's wrap there responses with
data
orresult
.But didn't implement it yet to keep it simple for now.
I hope you find it useful.
Happy Easter to everyone.