Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] Fix typehints #31806

Merged
merged 1 commit into from
Mar 6, 2020
Merged

[7.x] Fix typehints #31806

merged 1 commit into from
Mar 6, 2020

Conversation

driesvints
Copy link
Member

Fixes #31803

@driesvints driesvints mentioned this pull request Mar 6, 2020
Closed
@taylorotwell taylorotwell merged commit 9c1c839 into 7.x Mar 6, 2020
@driesvints driesvints deleted the fix-type-hints branch March 6, 2020 19:40
@GrahamCampbell
Copy link
Member

How as this not detected before? Do we have tests that invoke this code?

@driesvints
Copy link
Member Author

@GrahamCampbell we do. This baffles me as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Declaration of Illuminate\Foundation\Application::handle incompatible on 7.0.4
3 participants
@driesvints @GrahamCampbell @taylorotwell