[7.x] Added support for separation between geometry and geography types #30552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonkomarev
reviewed
Nov 9, 2019
| private function formatPostGisType(string $type, Fluent $column) | ||
| { | ||
| if ($column->geography !== null) { | ||
| return "geography($type, ".($column->projection === null ? '4326' : $column->projection).')'; |
There was a problem hiding this comment.
I'm not sure, but maybe it will be better to use sprintf method here for better readability?
There was a problem hiding this comment.
I actually just rewrote it with a null coalescer, for that exact reason. Still noodling about what to do on 906 for readability though.
|
The differences in this PR as opposed to #30545 are:
|
|
@raymondtri tests are failing. |
| private function formatPostGisType(string $type, Fluent $column) | ||
| { | ||
| if ($column->geography !== null) { | ||
| return "geography($type, ".($column->projection ?? '4326').')'; |
There was a problem hiding this comment.
return sprintf('geography(%s, %s)', $type, $column->projection ?? '4326');
|
Please submit with passing tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates directly to #30545, the arguments for setting geometry as the default type as opposed to the current default geography are there.
However since modifying this default is a breaking change, I believe it would be a pr for a new major version.
I will be updating the 6.x PR to be non-breaking.