[6.x] Added array to json conversion for sqlite #30133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@staudenmeir I hope this resolves the issue! |
driesvints
changed the title
staudenmeir
reviewed
Oct 1, 2019
| @@ -193,6 +193,12 @@ protected function compileUpdateWithJoinsOrLimit(Builder $query, array $values) | |||
| */ | |||
| public function prepareBindingsForUpdate(array $bindings, array $values) | |||
| { | |||
| $values = collect($values)->reject(function ($value, $column) { | |||
There was a problem hiding this comment.
Please remove the reject() clause. It's not relevant until we support JSON UPDATE queries on SQLite (i.e. ->update(['foo->bar' => 'baz'])).
There was a problem hiding this comment.
Ah right, thanks for that, I wasn't sure why it was there, the postgres grammer was built differently so a comparison was hard.
i-bajrai
added a commit
to i-bajrai/framework
that referenced
this pull request
Oct 4, 2019
* Added array to json conversion for sqlite * Removed reject from collection, not relevant unless using JSON queries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #30128, this PR allows SQLite databases to cast arrays as JSON when calling the update method directly on a model.
This allows a more consistent result when testing between mysql and sqlite, especially when using the
$castsarray on a model.