Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.8] Add hebrew letters to Str:slug language array #29838

Merged
merged 3 commits into from
Sep 3, 2019
Merged

[5.8] Add hebrew letters to Str:slug language array #29838

merged 3 commits into from
Sep 3, 2019

Conversation

GabMic
Copy link
Contributor

@GabMic GabMic commented Sep 3, 2019

This will add a Hebrew support to the Str::slug() helper.

@GrahamCampbell GrahamCampbell changed the title Add hebrew letters to Str:slug language array [5.8] Add hebrew letters to Str:slug language array Sep 3, 2019
@GrahamCampbell
Copy link
Member

Thanks for the PR. I think we'd probably accept this if it is accepted at https://github.com/danielstjules/Stringy.

@GabMic
Copy link
Contributor Author

GabMic commented Sep 3, 2019

Thanks for the PR. I think we'd probably accept this if it is accepted at https://github.com/danielstjules/Stringy.

That will be great.

@GabMic GabMic mentioned this pull request Sep 3, 2019
Closed
@taylorotwell taylorotwell merged commit 5147367 into laravel:5.8 Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GabMic @GrahamCampbell @taylorotwell