[5.8] Implement better email validation support #29589
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow for multiple email validators to be added when checking for valid emails. This is a continuation of the previous PR: #26503
Basically this allows for two things:
By default nothing's breaking because it'll still use the RFC validator to when no validators are passed to the email validation rule. But you can opt to include different ones or multiple ones:
Or opt for the pre-5.8 behavior:
Which will use
filter_var
to validate the email address. This should give people a little more flexibility when doing email validation.PS: I wasn't sure if we should return something for the
getError
andgetWarnings
methods in theFilterEmailValidation
class. I've left them with some defaults and everything seems to be working ok.