Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Fix exception message #29568

Merged
merged 1 commit into from
Aug 14, 2019
Merged

[5.8] Fix exception message #29568

merged 1 commit into from
Aug 14, 2019

Conversation

seriquynh
Copy link
Contributor

The manifestPath property is a dependency of ProviderRepository and was provided by Application::getCachedServicesPath(). It can be changed.

The current message exception is fixed and will be wrong if a developer changes his/her bootstrap/cace directory.

I also add a test for the case in which the directory doesn't exist.

@taylorotwell taylorotwell merged commit 43e7387 into laravel:5.8 Aug 14, 2019
@seriquynh seriquynh deleted the fix_exception_message branch August 15, 2019 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants