[5.8] Fix default theme for Markdown mails #29274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we don't need to set default theme value here.
The default theme is take care in Illuminate\Mail\Markdown::__constractut.
Leave it null as default so config('mail.markdown.theme') can take effect.
The default value of theme make the function no longger be called, it only called if it has value
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As metioned in this comment on pr #29132,
the pull request breaks the config
mail.markdown.themebecause it will be overwrited on:framework/src/Illuminate/Notifications/Channels/MailChannel.php
Lines 96 to 98 in aed06b1
This PR leave the
MailMessage::$themenull so MailChannel will ignore it.The feature added in PR #29132 still available.